gopherbot
commented
10 hours ago This PR (HEAD: 3414305a206194fd45727e15e028bad9902c2010) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/630715.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Setting GODEBUG=multipathtcp= [1] has no effects on apps using ListenTCP or DialTCP directly.
According to the documentation, these functions are supposed to act like Listen and Dial respectively:
So when reading this, I think we should expect GODEBUG=multipathtcp= to act on these functions as well.
Also, since #69016, MPTCP is used by default (if supported) with TCP listeners. Similarly, when ListenTCP is used directly, MPTCP is unexpectedly not used. It is strange to have a different behaviour.
So now, ListenTCP and DialTCP also check for MPTCP. Those are the exact same checks that are done in dial.go, see Listen and dialSingle.
[1] https://pkg.go.dev/net#Dialer.SetMultipathTCP
Fixes #70500