Closed antcs closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
âšī¸ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
âšī¸ Googlers: Go here for more info.
@antcs can you please create an issue for this PR. We like to discuss things before making any code changes and figure out what use cases things cover.
@codyoss I opened a new issue: https://github.com/golang/mock/issues/473
@googlebot I signed it!
@antcs Thanks for your contribution đ
Description
Found some missing error checks for the
os.SetEnv()
method inmockgen/parse_test.go
.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
Reviewer Notes
Release Notes
/
Fixes: #473