search

golang / mock

GoMock is a mocking framework for the Go programming language.
Apache License 2.0
9.28k stars 610 forks source link

fix ill-formatted message with fmt-verbs like %s #564

Closed motemen closed 3 years ago

motemen commented 3 years ago

If fmt-verb strings such as %s is included in the error message, the output becomes %!s(MISSING) unintendedly.

This pull request fixes this problem.

codyoss commented 3 years ago

@motemen Could you please create an issue for the PR first for discussion. In that issue can you provide an example where this affects usage? Thanks.

motemen commented 3 years ago

Thanks, filed a issue at https://github.com/golang/mock/issues/565 .

codyoss commented 3 years ago

@motemen Thank you for your contribution 🎆