fix parse array with the external const correctly

golang / mock

GoMock is a mocking framework for the Go programming language.

Apache License 2.0

9.28k stars 610 forks source link

Closed sryoya closed 3 years ago

sryoya commented 3 years ago

Fixes #561 - Panic on array parsing if length is externally defined

It also fixes the following minor problems in TestParseArrayWithConstLength, a test function related to this feature.

It doesn't check all outputs to be asserted.
It doesn't initialize some of the fields in mockgen.fileParser, even though they are initialized in the production code. (Actually, it caused an unnecessary test error by test data I added)

sryoya commented 3 years ago

Thanks for the review 🌵 I've either fixed or replied to your comments.

codyoss commented 3 years ago

@sryoya Thank you for your contribution! 🎆