search

golang / mock

GoMock is a mocking framework for the Go programming language.
Apache License 2.0
9.28k stars 610 forks source link

Add go 1.17.x to the matrix build #583

Closed kishaningithub closed 2 years ago

kishaningithub commented 2 years ago

When i ran this in my local with go 1.17 gofmt did not produce any error though. Any clues?

kishaningithub commented 2 years ago

Checked this with the docker container as well. (Screenshot below)

Screenshot 2021-08-30 at 10 28 19 AM
codyoss commented 2 years ago

Hey @kishaningithub Thanks for the PR. This is due to changes in how build constants are described in newer versions of Go. If you run goimports -w . from the repo root I think that should apply all the corrections needed. (Assuming you have 1.17 installed). Also would you mind removing 1.16 from the matrix. I think it is fine to test the oldest version we are compatible with and the latest.

codyoss commented 2 years ago

Close this PR, I will add 1.17 when I have the chance.