search

golang / mock

GoMock is a mocking framework for the Go programming language.
Apache License 2.0
9.28k stars 610 forks source link

Fix: missing ignore Fatal in SetArg function #594

Closed lovung closed 2 years ago

lovung commented 2 years ago

In my https://github.com/golang/mock/pull/589, I missed to add the skip line in switch case.

lovung commented 2 years ago

@codyoss Please help to review this PR when you have time. Thanks.

lovung commented 2 years ago

@codyoss Hello, could you help to review this PR?

google-cla[bot] commented 2 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

lovung commented 2 years ago

@googlebot I fixed it.

google-cla[bot] commented 2 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

lovung commented 2 years ago

@codyoss Hello, could you help to review this PR?

lovung commented 2 years ago

@codyoss ping

lovung commented 2 years ago

@codyoss Could you help to review my MR again?