Closed tra4less closed 9 months ago
Hi, is there any progress on this PR?
Hey, any updates here?
cc @codyoss
any progress on this?
Hey @codyoss , is there anything @n0trace/we/anyone can do to help get this PR reviewed and approved?
The implementation changed, by adding a flag. @codyoss @Trim21 reference #622
add new flag in readme?
@codyoss @n0trace any progress with the PR?
cc @codyoss
@codyoss Is any ETA for review of the PR?
Would love to see this reviewed. Putting the feature behind a new flag seems like a good way to introduce it.
/ping
Bump. This would be very useful.
cc @codyoss
hi @n0trace , this also requires one additional fix for optional vars.
Example interface:
import (
"context"
"fmt"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/config"
"github.com/aws/aws-sdk-go-v2/service/s3"
)
type s3Client interface {
HeadBucket(ctx context.Context, input *s3.HeadBucketInput, opts ...func(*s3.Options)) (*s3.HeadBucketOutput, error)
}
will generate incorrect mock Return func: fix is https://github.com/skynet2/mock/commit/ca75ee65a535230e0f517a626f35d48646b50d0b
Thanks
@codyoss can anyone review this PR?
@codyoss can anyone review this PR?
Good news: Codyoss' github is highly active. Bad news: Not active in this repository.
622 #427 #634 #657