Closed dhiaayachi closed 3 months ago
This PR (HEAD: bfaf7fcb1fefe67de5ea95203e464e0883b0ac20) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/oscar/+/603756.
Important tips:
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 3:
(7 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 0aa76bcdd0be101cbd8597053e046685ef3ade1b) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/oscar/+/603756.
Important tips:
Message from Ian Lance Taylor:
Patch Set 5:
(9 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: df6950d4cb87bdd6c19ecbab36d718785dc25fcb) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/oscar/+/603756.
Important tips:
Message from Ian Lance Taylor:
Patch Set 6: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-08-07T20:26:44Z","revision":"197da22d9f2d644a85c11b9bb4280e1d6bb1eabd"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 6: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 6:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 9dd25218687a66d05f21cd5d182a143912d94fad) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/oscar/+/603756.
Important tips:
Message from Ian Lance Taylor:
Patch Set 7: Commit-Queue+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 7:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-08-08T23:25:30Z","revision":"ecb5535b2dc7fd1554f28b39ccc7cc0b2d268870"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 7: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 7:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 7: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 7: Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 7:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 7: Auto-Submit+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
Message from Zvonimir Pavlinovic:
Patch Set 7: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/603756. After addressing review feedback, remember to publish your drafts!
This PR is being closed because golang.org/cl/603756 has been merged.
Adding the model name allows using different models as needed and also avoids hard-coding what will eventually become an old model.