search

golang / protobuf

Go support for Google's protocol buffers
BSD 3-Clause "New" or "Revised" License
9.74k stars 1.58k forks source link

Update internal/benchmarks to work with fleetbench #1570

Closed stapelberg closed 11 months ago

stapelberg commented 11 months ago

https://github.com/protocolbuffers/protobuf-go/blob/f4a6c1f6e5c183174c1ea206ed49916e8f1dd1e8/internal/benchmarks/download_benchdata.bash#L17 is broken because the datasets no longer exist.

The benchmark should be adjusted to work with https://github.com/google/fleetbench instead.

puellanivis commented 11 months ago

Isn’t this a duplicate of https://github.com/golang/protobuf/issues/1524

stapelberg commented 11 months ago

Definitely. Thanks for pointing that out, I didn’t see that one.