search

golang / snappy

The Snappy compression format in the Go programming language.
BSD 3-Clause "New" or "Revised" License
1.52k stars 163 forks source link

Fuzz new decoder implementation? #25

Closed dgryski closed 8 years ago

dgryski commented 8 years ago

The existing Go decoded was no doubt tested with go-fuzz. Does the new asm decoder also need heavy testing with bad inputs?

nigeltao commented 8 years ago

Probably. Honest question: are you volunteering?

dgryski commented 8 years ago

I can find some time to do this. I will also use the fuzz function to ensure identical output between the pure-Go decoder and the assembly version.

dgryski commented 8 years ago

I've now run several billion fuzz attmempts through https://gist.github.com/dgryski/6f1b8caebf65dc489f7b with no crashes. Note this requires renaming the decoder routines slightly so that both the Go and the assembly decoder are available.

This can probably be closed.