search

golang / snappy

The Snappy compression format in the Go programming language.
BSD 3-Clause "New" or "Revised" License
1.52k stars 163 forks source link

asm/amd64: remove the unused code, and reduce the frame size #35

Closed chai2010 closed 8 years ago

nigeltao commented 8 years ago

I'm not sure if it's unused code. I don't think the calling convention guarantees that callees will not modify the args on the stack.

I started a golang-dev discussion at https://groups.google.com/d/topic/golang-dev/8RywCWxHVYA/discussion

nigeltao commented 8 years ago

That discussion suggests that, in general, you can't assume that callees won't modify the args on the stack, so this isn't actually unused code.