Closed tekig closed 8 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
This PR (HEAD: fe6daed2ee97e8aef97ddeb142efa3a0b09ffd69) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/549299.
Important tips:
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: d714e8b1a7d824560f2d957dc90d0837bcfbd5b7) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/549299.
Important tips:
Message from Dell:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from Hyang-Ah Hana Kim:
Patch Set 6: Code-Review+2
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from Hyang-Ah Hana Kim:
Patch Set 6: Auto-Submit+1 Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 6: Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from Hyang-Ah Hana Kim:
Patch Set 7: Auto-Submit+1 Code-Review+2 Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from Robert Findley:
Patch Set 7:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 7:
Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/c1f2c9a5-4f09-46d1-9718-ff6ce70b021f
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 7: TryBot-Result-1
Kokoro presubmit build finished with status: FAILURE Logs at: https://source.cloud.google.com/results/invocations/c1f2c9a5-4f09-46d1-9718-ff6ce70b021f
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from Hyang-Ah Hana Kim:
Patch Set 7:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 1187a46b797271a47d154765e76912e619176735) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/549299.
Important tips:
Message from Hyang-Ah Hana Kim:
Patch Set 8: Auto-Submit+1 Code-Review+2 Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from Hyang-Ah Hana Kim:
Patch Set 8: Auto-Submit+1 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 8:
Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit Logs at: http://sponge2.corp.google.com/3dc39bcd-248b-447a-a343-3901fcd02371
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 8:
Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/3dc39bcd-248b-447a-a343-3901fcd02371
Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!
This PR is being closed because golang.org/cl/549299 has been merged.
It is not possible to open a web view directly through a local server. Pprof is launched by default via localhost on the remote server. This means that for a remotely running workspace extension, the webviews it creates would not be able to access local servers spawned by the extension.
After fix:![image](https://github.com/golang/vscode-go/assets/19306721/2a193915-9145-4b0e-9f1f-531549e4bc31)
Pprof uses absolute references. This means it won't work for codespace, but this completely works for vscode. To fix it, need to change the page rendering in pprof.
Fixes #3090