src/goTest: fix display pprof result page when using ssh

tekig commented 8 months ago

It is not possible to open a web view directly through a local server. Pprof is launched by default via localhost on the remote server. This means that for a remotely running workspace extension, the webviews it creates would not be able to access local servers spawned by the extension.

After fix:

Pprof uses absolute references. This means it won't work for codespace, but this completely works for vscode. To fix it, need to change the page rendering in pprof.

Fixes #3090

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot commented 8 months ago

This PR (HEAD: fe6daed2ee97e8aef97ddeb142efa3a0b09ffd69) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/549299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot commented 8 months ago

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

This PR (HEAD: d714e8b1a7d824560f2d957dc90d0837bcfbd5b7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/549299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot commented 8 months ago

Message from Dell:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from Hyang-Ah Hana Kim:

Patch Set 6: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from Hyang-Ah Hana Kim:

Patch Set 6: Auto-Submit+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from Alan Donovan:

Patch Set 6: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from Hyang-Ah Hana Kim:

Patch Set 7: Auto-Submit+1 Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from Robert Findley:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from kokoro:

Patch Set 7:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/c1f2c9a5-4f09-46d1-9718-ff6ce70b021f

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from kokoro:

Patch Set 7: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE Logs at: https://source.cloud.google.com/results/invocations/c1f2c9a5-4f09-46d1-9718-ff6ce70b021f

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from Hyang-Ah Hana Kim:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

This PR (HEAD: 1187a46b797271a47d154765e76912e619176735) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/549299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot commented 8 months ago

Message from Hyang-Ah Hana Kim:

Patch Set 8: Auto-Submit+1 Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from Hyang-Ah Hana Kim:

Patch Set 8: Auto-Submit+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from kokoro:

Patch Set 8:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit Logs at: http://sponge2.corp.google.com/3dc39bcd-248b-447a-a343-3901fcd02371

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

Message from kokoro:

Patch Set 8:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/3dc39bcd-248b-447a-a343-3901fcd02371

Please don’t reply on this GitHub thread. Visit golang.org/cl/549299. After addressing review feedback, remember to publish your drafts!

gopherbot commented 8 months ago

This PR is being closed because golang.org/cl/549299 has been merged.

golang / vscode-go

src/goTest: fix display pprof result page when using ssh #3089