search

golang / vscode-go

Go extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=golang.Go
Other
3.87k stars 745 forks source link

debug: support completion/suggestion in debug console #3134

Open shellwhale opened 8 months ago

shellwhale commented 8 months ago

What version of Go, VS Code & VS Code Go extension are you using?

Version Information
* Run `go version` to get version of Go from _the VS Code integrated terminal_. - go version go1.21.6 windows/amd64 * Run `gopls -v version` to get version of Gopls from _the VS Code integrated terminal_. - Build info ---------- golang.org/x/tools/gopls v0.14.2 golang.org/x/tools/gopls@v0.14.2 h1:sIw6vjZiuQ9S7s0auUUkHlWgsCkKZFWDHmrge8LYsnc= github.com/BurntSushi/toml@v1.2.1 h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak= github.com/google/go-cmp@v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38= github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0= golang.org/x/exp/typeparams@v0.0.0-20221212164502-fae10dda9338 h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH3x7MAiqGW6Y= golang.org/x/mod@v0.14.0 h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0= golang.org/x/sync@v0.4.0 h1:zxkM55ReGkDlKSM+Fu41A+zmbZuaPVbGMzvvdUPznYQ= golang.org/x/sys@v0.14.0 h1:Vz7Qs629MkJkGyHxUlRHizWJRG2j8fbQKjELVSNhy7Q= golang.org/x/telemetry@v0.0.0-20231114163143-69313e640400 h1:brbkEFfGwNGAEkykUOcryE/JiHUMMJouzE0fWWmz/QU= golang.org/x/text@v0.13.0 h1:ablQoSUd0tRdKxZewP80B+BaqeKJuVhuRxj/dkrun3k= golang.org/x/tools@v0.14.1-0.20231114185516-c9d3e7de13fd h1:Oku7E+OCrXHyst1dG1z10etCTxewCHXNFLRlyMPbh3w= golang.org/x/vuln@v1.0.1 h1:KUas02EjQK5LTuIx1OylBQdKKZ9jeugs+HiqO5HormU= honnef.co/go/tools@v0.4.5 h1:YGD4H+SuIOOqsyoLOpZDWcieM28W47/zRO7f+9V3nvo= mvdan.cc/gofumpt@v0.4.0 h1:JVf4NN1mIpHogBj7ABpgOyZc65/UUOkKQFkoURsz4MM= mvdan.cc/xurls/v2@v2.4.0 h1:tzxjVAj+wSBmDcF6zBB7/myTy3gX9xvi8Tyr28AuQgc= go: go1.21.0 * Run `code -v` or `code-insiders -v` to get version of VS Code or VS Code Insiders. - 1.85.1 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2 x64 * Check your installed extensions to get the version of the VS Code Go extension - v0.40.1 * Run Ctrl+Shift+P (Cmd+Shift+P on Mac OS) > `Go: Locate Configured Go Tools` command. - go: C:\Users\shellwhale\scoop\shims\go.exe: go version go1.21.0 windows/amd64 gopls: C:\Users\shellwhale\go\bin\gopls.exe (version: v0.14.2 built with go: go1.21.0) gotests: not installed gomodifytags: not installed impl: not installed goplay: not installed dlv: C:\Users\shellwhale\go\bin\dlv.exe (version: v1.21.0 built with go: go1.21.0) staticcheck: C:\Users\shellwhale\go\bin\staticcheck.exe (version: v0.4.3 built with go: go1.21.0)

Describe the bug

Debug Console Suggestions are not working

Steps to reproduce the behavior:

image

Here is an example of debug console suggestions working with the Python debugger

image

shellwhale commented 8 months ago

It looks like there is already Delve support for this https://github.com/go-delve/delve/pull/3004

hyangah commented 8 months ago

The delve feature is for dlv cli. I don't know how this can be implemented on top of DAP. Or is there VS Code specific capability to utilize?

hyangah commented 8 months ago

https://microsoft.github.io/debug-adapter-protocol//specification.html#Requests_Completions

Delve DAP currently does not support this capability. cc @suzmue

diegolatorre116 commented 5 months ago

This would be a great feature! It would greatly improve the user experience