Closed ossan-dev closed 1 month ago
This PR (HEAD: 1ccb62d4b8e47df8843917d53767ab2d9d00a4eb) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/571955.
Important tips:
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from Hyang-Ah Hana Kim:
Patch Set 2: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 2:
Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit Logs at: http://sponge2.corp.google.com/1aa0dc35-c7a1-493a-89b6-95df4618ae6b
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 2:
Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/1aa0dc35-c7a1-493a-89b6-95df4618ae6b
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 2: kokoro-CI-1
Kokoro presubmit build finished with status: FAILURE Logs at: https://source.cloud.google.com/results/invocations/1aa0dc35-c7a1-493a-89b6-95df4618ae6b
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: f9be4890c812f47edce96e27099848ceb9c0a42e) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/571955.
Important tips:
Message from Ian Lance Taylor:
Patch Set 3:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 3: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 3:
Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit Logs at: http://sponge2.corp.google.com/d3123b63-562e-43f4-bf10-f5cecec29dcc
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 3:
Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/d3123b63-562e-43f4-bf10-f5cecec29dcc
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 3: kokoro-CI+1
Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/d3123b63-562e-43f4-bf10-f5cecec29dcc
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 3: Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from David Chase:
Patch Set 3: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
Message from Hyang-Ah Hana Kim:
Patch Set 3: Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/571955. After addressing review feedback, remember to publish your drafts!
This PR is being closed because golang.org/cl/571955 has been merged.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.