search

golang / vscode-go

Go extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=golang.Go
Other
3.78k stars 728 forks source link

vscode-go: changing testFlag setting requires restart #3291

Open pjweinb opened 3 months ago

pjweinb commented 3 months ago

Go version

go version go1.23-20240317-RC00 cl/616607620 +0a6f05e30f X:fieldtrack,boringcrypto linux/amd64

Output of go env in your module/workspace:

doesn't matter

What did you do?

in settings.json, i changed the value of go.TestFlags

What did you see happen?

clicking on the "run test | debug test" line above the function definition no longer works, requiring gopls to be restarted (Developer: reload window)

What did you expect to see?

At least a warning that the window needed to be reloaded. It would be even better if the window did not have to be reloaded.

pjweinb commented 3 months ago

This doesn't always happen, and I'm not sure when it does or doesn't.

findleyr commented 2 months ago

CC @hyangah

findleyr commented 2 months ago

At the very least, this should be deterministic, and generally the expectation is that setting changes take effect immediately.