golang / vscode-go

Go extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=golang.Go
Other
3.78k stars 727 forks source link

Govulncheck integration test is broken with gopls v0.16.0 #3427

Closed hyangah closed 1 day ago

hyangah commented 1 week ago

The vscode integration test had been used "Share feedback at https://go.dev/s/govulncheck-feedback." as the signal for the end of govulncheck text output display. gopls v0.16.0 uses x/vuln v1.0.4 and it looks like x/vuln doesn't spit out the info any more. Stop depending on it.

Easiest is to pick different patterns, but that's still hacky and can break any time. Better approach is to check the progress report end message.

hyangah commented 1 day ago

Fixed.