golang / vscode-go

Go extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=golang.Go
Other
3.87k stars 750 forks source link

PATH in Terminal is not automatically updated to include GOROOT/bin #3532

Open TLCFEM opened 1 month ago

TLCFEM commented 1 month ago

I think it is a bug on Windows. I vaguely remember that I used to directly invoke go in ps.

Here on linux, PATH is correctly set in terminals.

Code_n9WZhYtvQm

But on Windows, PATH is not updated.

Code_twleohXIMi

Originally posted by @TLCFEM in https://github.com/golang/vscode-go/issues/3522#issuecomment-2341934681

TLCFEM commented 1 month ago

Maybe this if condition shall be revised.

https://github.com/golang/vscode-go/blob/725259766181b4be91ed84411d6ac564a5ab2e5a/extension/src/goEnvironmentStatus.ts#L390

findleyr commented 3 weeks ago

Thanks, we think this is an upstream bug, but it requires additional investigation.

leagmain commented 1 week ago

I also have the same issue on MacOS Sequoia 15.0.1.

image

Here is the PATH outputs in integrated terminal. ✗ echo $PATH

/Users/mllei/.pyenv/versions/3.12.1/bin:/opt/homebrew/opt/libpq/bin:/opt/homebrew/opt/mysql-client/bin:/Users/mllei/.pyenv/shims:/Users/mllei/.docker/bin:/Users/mllei/.pyenv/versions/3.12.1/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/Users/mllei/.pyenv/versions/3.12.1/bin:/opt/homebrew/opt/libpq/bin:/opt/homebrew/opt/mysql-client/bin:/Users/mllei/.docker/bin:/Users/mllei/Library/Application Support/JetBrains/Toolbox/scripts:/Users/mllei/Library/Android/sdk/platform-tools:/Users/mllei/.pub-cache/bin:/Users/mllei/Applications/flutter/bin:/opt/homebrew/opt/kafka/bin/:/Users/mllei/Library/Application Support/JetBrains/Toolbox/scripts:/Users/mllei/Library/Android/sdk/platform-tools:/Users/mllei/.pub-cache/bin:/Users/mllei/Applications/flutter/bin:/opt/homebrew/opt/kafka/bin/:/Users/mllei/go/bin