golangci / golangci-lint

Fast linters runner for Go
https://golangci-lint.run
GNU General Public License v3.0
15.56k stars 1.38k forks source link

golangci-lint install fails version above 1.50.0 #4311

Closed kart2 closed 9 months ago

kart2 commented 9 months ago

Welcome

Description of the problem

The go install command fails with the following error.

vendor/github.com/ryancurrah/gomodguard/tools.go:5:8: import "github.com/t-yuki/gocover-cobertura" is a program, not an importable package

Version of golangci-lint

```console $ golangci-lint --version v.1.55.2 ```

Configuration

```console No custom configuration file is used. ```

Go environment

```console $ go version && go env go version go1.21.3 darwin/amd64 ```

Verbose output of running

```console $ golangci-lint cache clean $ golangci-lint run -v unable to install it ```

A minimal reproducible example or link to a public repository

```go https://github.com/kcp-dev/kcp/blob/main/hack/go-install.sh ./hack/go-install.sh github.com/golangci/golangci-lint/cmd/golangci-lint golangci-lint v1.55.2 go: creating new go.mod: module tools Initialized empty Git repository in /private/var/folders/vw/k1jqgfn94lndt5_jbcs2vxx00000gp/T/goinstall_XXXXXXXXXX.7ZNsy5MJl6/.git/ go: added 4d63.com/gocheckcompilerdirectives v1.2.1 go: added 4d63.com/gochecknoglobals v0.2.1 go: added github.com/4meepo/tagalign v1.3.3 go: added github.com/Abirdcfly/dupword v0.0.13 go: added github.com/Antonboom/errname v0.1.12 go: added github.com/Antonboom/nilnil v0.1.7 go: added github.com/Antonboom/testifylint v0.2.3 go: added github.com/BurntSushi/toml v1.3.2 go: added github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24 go: added github.com/GaijinEntertainment/go-exhaustruct/v3 v3.1.0 go: added github.com/Masterminds/semver v1.5.0 go: added github.com/OpenPeeDeeP/depguard/v2 v2.1.0 go: added github.com/alecthomas/go-check-sumtype v0.1.3 go: added github.com/alexkohler/nakedret/v2 v2.0.2 go: added github.com/alexkohler/prealloc v1.0.0 go: added github.com/alingse/asasalint v0.0.11 go: added github.com/ashanbrown/forbidigo v1.6.0 go: added github.com/ashanbrown/makezero v1.1.1 go: added github.com/beorn7/perks v1.0.1 go: added github.com/bkielbasa/cyclop v1.2.1 go: added github.com/blizzy78/varnamelen v0.8.0 go: added github.com/bombsimon/wsl/v3 v3.4.0 go: added github.com/breml/bidichk v0.2.7 go: added github.com/breml/errchkjson v0.3.6 go: added github.com/butuzov/ireturn v0.2.2 go: added github.com/butuzov/mirror v1.1.0 go: added github.com/catenacyber/perfsprint v0.2.0 go: added github.com/ccojocar/zxcvbn-go v1.0.1 go: added github.com/cespare/xxhash/v2 v2.1.2 go: added github.com/charithe/durationcheck v0.0.10 go: added github.com/chavacava/garif v0.1.0 go: added github.com/curioswitch/go-reassign v0.2.0 go: added github.com/daixiang0/gci v0.11.2 go: added github.com/davecgh/go-spew v1.1.1 go: added github.com/denis-tingaikin/go-header v0.4.3 go: added github.com/esimonov/ifshort v1.0.4 go: added github.com/ettle/strcase v0.1.1 go: added github.com/fatih/color v1.15.0 go: added github.com/fatih/structtag v1.2.0 go: added github.com/firefart/nonamedreturns v1.0.4 go: added github.com/fsnotify/fsnotify v1.5.4 go: added github.com/fzipp/gocyclo v0.6.0 go: added github.com/ghostiam/protogetter v0.2.3 go: added github.com/go-critic/go-critic v0.9.0 go: added github.com/go-toolsmith/astcast v1.1.0 go: added github.com/go-toolsmith/astcopy v1.1.0 go: added github.com/go-toolsmith/astequal v1.1.0 go: added github.com/go-toolsmith/astfmt v1.1.0 go: added github.com/go-toolsmith/astp v1.1.0 go: added github.com/go-toolsmith/strparse v1.1.0 go: added github.com/go-toolsmith/typep v1.1.0 go: added github.com/go-xmlfmt/xmlfmt v1.1.2 go: added github.com/gobwas/glob v0.2.3 go: added github.com/gofrs/flock v0.8.1 go: added github.com/golang/protobuf v1.5.2 go: added github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2 go: added github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a go: added github.com/golangci/go-misc v0.0.0-20220329215616-d24fe342adfe go: added github.com/golangci/gofmt v0.0.0-20231018234816-f50ced29576e go: added github.com/golangci/golangci-lint v1.55.2 go: added github.com/golangci/lint-1 v0.0.0-20191013205115-297bf364a8e0 go: added github.com/golangci/maligned v0.0.0-20180506175553-b1d89398deca go: added github.com/golangci/misspell v0.4.1 go: added github.com/golangci/revgrep v0.5.2 go: added github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4 go: added github.com/google/go-cmp v0.6.0 go: added github.com/gordonklaus/ineffassign v0.0.0-20230610083614-0e73809eb601 go: added github.com/gostaticanalysis/analysisutil v0.7.1 go: added github.com/gostaticanalysis/comment v1.4.2 go: added github.com/gostaticanalysis/forcetypeassert v0.1.0 go: added github.com/gostaticanalysis/nilerr v0.1.1 go: added github.com/hashicorp/errwrap v1.0.0 go: added github.com/hashicorp/go-multierror v1.1.1 go: added github.com/hashicorp/go-version v1.6.0 go: added github.com/hashicorp/hcl v1.0.0 go: added github.com/hexops/gotextdiff v1.0.3 go: added github.com/inconshreveable/mousetrap v1.1.0 go: added github.com/jgautheron/goconst v1.6.0 go: added github.com/jingyugao/rowserrcheck v1.1.1 go: added github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af go: added github.com/julz/importas v0.1.0 go: added github.com/kisielk/errcheck v1.6.3 go: added github.com/kisielk/gotool v1.0.0 go: added github.com/kkHAIKE/contextcheck v1.1.4 go: added github.com/kulti/thelper v0.6.3 go: added github.com/kunwardeep/paralleltest v1.0.8 go: added github.com/kyoh86/exportloopref v0.1.11 go: added github.com/ldez/gomoddirectives v0.2.3 go: added github.com/ldez/tagliatelle v0.5.0 go: added github.com/leonklingele/grouper v1.1.1 go: added github.com/lufeee/execinquery v1.2.1 go: added github.com/macabu/inamedparam v0.1.2 go: added github.com/magiconair/properties v1.8.6 go: added github.com/maratori/testableexamples v1.0.0 go: added github.com/maratori/testpackage v1.1.1 go: added github.com/matoous/godox v0.0.0-20230222163458-006bad1f9d26 go: added github.com/mattn/go-colorable v0.1.13 go: added github.com/mattn/go-isatty v0.0.17 go: added github.com/mattn/go-runewidth v0.0.9 go: added github.com/matttproud/golang_protobuf_extensions v1.0.1 go: added github.com/mbilski/exhaustivestruct v1.2.0 go: added github.com/mgechev/revive v1.3.4 go: added github.com/mitchellh/go-homedir v1.1.0 go: added github.com/mitchellh/mapstructure v1.5.0 go: added github.com/moricho/tparallel v0.3.1 go: added github.com/nakabonne/nestif v0.3.1 go: added github.com/nishanths/exhaustive v0.11.0 go: added github.com/nishanths/predeclared v0.2.2 go: added github.com/nunnatsa/ginkgolinter v0.14.1 go: added github.com/olekukonko/tablewriter v0.0.5 go: added github.com/pelletier/go-toml v1.9.5 go: added github.com/pelletier/go-toml/v2 v2.0.5 go: added github.com/pmezard/go-difflib v1.0.0 go: added github.com/polyfloyd/go-errorlint v1.4.5 go: added github.com/prometheus/client_golang v1.12.1 go: added github.com/prometheus/client_model v0.2.0 go: added github.com/prometheus/common v0.32.1 go: added github.com/prometheus/procfs v0.7.3 go: added github.com/quasilyte/go-ruleguard v0.4.0 go: added github.com/quasilyte/gogrep v0.5.0 go: added github.com/quasilyte/regex/syntax v0.0.0-20210819130434-b3f0c404a727 go: added github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 go: added github.com/ryancurrah/gomodguard v1.3.0 go: added github.com/ryanrolds/sqlclosecheck v0.5.1 go: added github.com/sanposhiho/wastedassign/v2 v2.0.7 go: added github.com/sashamelentyev/interfacebloat v1.1.0 go: added github.com/sashamelentyev/usestdlibvars v1.24.0 go: added github.com/securego/gosec/v2 v2.18.2 go: added github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c go: added github.com/sirupsen/logrus v1.9.3 go: added github.com/sivchari/containedctx v1.0.3 go: added github.com/sivchari/nosnakecase v1.7.0 go: added github.com/sivchari/tenv v1.7.1 go: added github.com/sonatard/noctx v0.0.2 go: added github.com/sourcegraph/go-diff v0.7.0 go: added github.com/spf13/afero v1.8.2 go: added github.com/spf13/cast v1.5.0 go: added github.com/spf13/cobra v1.7.0 go: added github.com/spf13/jwalterweatherman v1.1.0 go: added github.com/spf13/pflag v1.0.5 go: added github.com/spf13/viper v1.12.0 go: added github.com/ssgreg/nlreturn/v2 v2.2.1 go: added github.com/stbenjam/no-sprintf-host-port v0.1.1 go: added github.com/stretchr/objx v0.5.0 go: added github.com/stretchr/testify v1.8.4 go: added github.com/subosito/gotenv v1.4.1 go: added github.com/t-yuki/gocover-cobertura v0.0.0-20180217150009-aaee18c8195c go: added github.com/tdakkota/asciicheck v0.2.0 go: added github.com/tetafro/godot v1.4.15 go: added github.com/timakin/bodyclose v0.0.0-20230421092635-574207250966 go: added github.com/timonwong/loggercheck v0.9.4 go: added github.com/tomarrell/wrapcheck/v2 v2.8.1 go: added github.com/tommy-muehle/go-mnd/v2 v2.5.1 go: added github.com/ultraware/funlen v0.1.0 go: added github.com/ultraware/whitespace v0.0.5 go: added github.com/uudashr/gocognit v1.1.2 go: added github.com/xen0n/gosmopolitan v1.2.2 go: added github.com/yagipy/maintidx v1.0.0 go: added github.com/yeya24/promlinter v0.2.0 go: added github.com/ykadowak/zerologlint v0.1.3 go: added gitlab.com/bosi/decorder v0.4.1 go: added go-simpler.org/sloglint v0.1.2 go: added go.tmz.dev/musttag v0.7.2 go: added go.uber.org/atomic v1.7.0 go: added go.uber.org/multierr v1.6.0 go: added go.uber.org/zap v1.24.0 go: added golang.org/x/exp v0.0.0-20230510235704-dd950f8aeaea go: added golang.org/x/exp/typeparams v0.0.0-20230307190834-24139beb5833 go: added golang.org/x/mod v0.13.0 go: added golang.org/x/sync v0.4.0 go: added golang.org/x/sys v0.13.0 go: added golang.org/x/text v0.13.0 go: added golang.org/x/tools v0.14.0 go: added google.golang.org/protobuf v1.28.0 go: added gopkg.in/ini.v1 v1.67.0 go: added gopkg.in/yaml.v2 v2.4.0 go: added gopkg.in/yaml.v3 v3.0.1 go: added honnef.co/go/tools v0.4.6 go: added mvdan.cc/gofumpt v0.5.0 go: added mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed go: added mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b go: added mvdan.cc/unparam v0.0.0-20221223090309-7455f1af531d vendor/github.com/ryancurrah/gomodguard/tools.go:5:8: import "github.com/t-yuki/gocover-cobertura" is a program, not an importable package ```

Validation

boring-cyborg[bot] commented 9 months ago

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

ldez commented 9 months ago

Hello,

I think it's a problem related to your custom install script, because it works as expected:

$ docker run --rm -it golang:1.21-alpine sh
/go # apk add -q git curl
/go # go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2
go: downloading github.com/golangci/golangci-lint v1.55.2
go: downloading github.com/spf13/cobra v1.7.0
...
go: downloading google.golang.org/protobuf v1.28.0
go: downloading github.com/mattn/go-runewidth v0.0.9
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
/go # golangci-lint version
golangci-lint has version v1.55.2 built with go1.21.3 from (unknown, mod sum: "h1:yllEIsSJ7MtlDBwDJ9IMBkyEUz2fYE0b5B8IUgO1oP8=") on (unknown)