search

golangci / golangci-lint

Fast linters runner for Go
https://golangci-lint.run
GNU General Public License v3.0
15.44k stars 1.38k forks source link

build(deps): bump github.com/securego/gosec/v2 from 2.20.0 to 5f0084eb01a9 #4748

Closed ldez closed 4 months ago

ldez commented 4 months ago

The update is done by hand because gosec is not released yet, and this is an important performance issue.

This update is safe because it only contains the Go version fix.

https://github.com/securego/gosec/compare/v2.20.0...5f0084eb01a9

Comparison with v1.58.1:

Benchmark 1: ./golangci-lint run --print-issued-lines=false --enable-only gosec
  Time (mean ± σ):     569.2 ms ±  21.2 ms    [User: 2152.1 ms, System: 956.9 ms]
  Range (min … max):   540.0 ms … 613.3 ms    10 runs

Benchmark 2: ./golangci-lint-v1.58.1 run --print-issued-lines=false --enable-only gosec
  Time (mean ± σ):     536.4 ms ±  28.1 ms    [User: 2158.7 ms, System: 886.2 ms]
  Range (min … max):   503.9 ms … 595.6 ms    10 runs

Comparison with v1.58.2:

Benchmark 1: ./golangci-lint run --print-issued-lines=false --enable-only gosec
  Time (mean ± σ):     548.2 ms ±  19.9 ms    [User: 2160.2 ms, System: 840.1 ms]
  Range (min … max):   524.6 ms … 578.9 ms    10 runs

Benchmark 2: ./golangci-lint-v1.58.2 run --print-issued-lines=false --enable-only gosec
  Time (mean ± σ):      2.668 s ±  0.078 s    [User: 7.854 s, System: 4.924 s]
  Range (min … max):    2.607 s …  2.862 s    10 runs

Those benchmarks are done with a golangci-lint cache clean before each benchmark.

Fixes #4735