golangci / golangci-lint

Fast linters runner for Go
https://golangci-lint.run
GNU General Public License v3.0
14.85k stars 1.34k forks source link

lll: Advertise max line length instead of just reporting failure #4781

Closed blast-hardcheese closed 3 weeks ago

blast-hardcheese commented 1 month ago

Pardon if this has been discussed before, I couldn't find it in the issue/PR list.

As a user, I find it disorienting when tools inform me that I have made a mistake but do not offer any insights into how to resolve the issue.

In this case in particular, we have all the information, but then require the user to know the defaults and to traverse the config overrides.

It'd be nice to just provide this information. Impact to existing users should be minimal, including data transfer or storage of logs in CI, since teams who are already in compliance would not get the new log component, and teams who are not in compliance yet would get the message once and then be done.

Happy to circle back if there's prior art for how this information should be displayed.

Thanks!

boring-cyborg[bot] commented 1 month ago

Hey, thank you for opening your first Pull Request !

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

ldez commented 1 month ago

Hello, it's a good suggestion, I rephrased the message to be more explicit.