dev: improve readability and maintenance of `internal/cache` - Githubissues

golangci / golangci-lint

Fast linters runner for Go

https://golangci-lint.run

GNU General Public License v3.0

15.74k stars 1.39k forks source link

dev: improve readability and maintenance of `internal/cache` #5101

Closed ldez closed 2 weeks ago

ldez commented 2 weeks ago

Before reviewing the content of this PR, and if you want, I propose a quick "game" to illustrate the goal of this PR:

Open the current version of internal/cache/cache.go locally
You have 10 seconds to read and explain what the method Get is doing
Now open my version of the method Get and do the same thing
Do you see the difference? :smile_cat:

Extends stopwatch to simplify the usage.

Isolates usage of iosem.

Factorizes methods to increase the readability.

Follows #5100