golangci / homebrew-tap

Homebrew Formula for golangci-lint
3 stars 15 forks source link

Please make this an official Homebrew formula #1

Closed leonklingele closed 3 years ago

leonklingele commented 5 years ago

Why not make this an official formula in Homebrew/homebrew-core? I prefer not having to use third party taps.

If it's because of automated releases, using brew bump-formula-pr makes it super easy to bump an official formula.

SVilgelm commented 4 years ago

The problem with an official formulas, that they should be delivered as a source code and compiled on a target machine, like your laptop/pc. So it requires a go installed. Maybe it's possible to put it into a cask repo, but they have some requirements of popularity of this tap

cblecker commented 4 years ago

@SVilgelm this isn't correct for official formulae. You can have go as only a build time dependency, and then the binary delivered in the bottle doesn't require go

SVilgelm commented 4 years ago

@cblecker we have a thread for the discussion about this issue: https://github.com/orgs/golangci/teams/team/discussions/2 Let use it

billinghamj commented 3 years ago

Poking this one again - the page you've linked is not accessible to people who aren't members of the golangci org

SVilgelm commented 3 years ago

The official formulae has been added to the main homebrew tap: https://formulae.brew.sh/formula/golangci-lint

leonklingele commented 3 years ago

Hey, that's awesome! 🐳