search

golangci / homebrew-tap

Homebrew Formula for golangci-lint
3 stars 15 forks source link

Please update to v1.28 #8

Closed SVilgelm closed 4 years ago

SVilgelm commented 4 years ago

Could you please update the formulae to the v1.28?

nigurr commented 4 years ago

@jirfag can we please get this updated with v1.28.1

SVilgelm commented 4 years ago

Looks like the goreleaser fails, I raised a pr to fix it: https://github.com/golangci/golangci-lint/pull/1215 the it should be updated automatically

SVilgelm commented 4 years ago

@golangci/core-team the release action fails[1] to update the tap repo, could you please validate that the GITHUB_TOKEN has write permissions for this repo?

[1] https://github.com/golangci/golangci-lint/runs/856068778?check_suite_focus=true#step:6:183

SVilgelm commented 4 years ago

sorry I mean the secrets.GOLANGCI_LINT_TOKEN token

nigurr commented 4 years ago

@golangci/core-team please resolve this.

edwarnicke commented 4 years ago

Actually... if I could ask for 1.28.3 :)

SVilgelm commented 4 years ago

we just need to solve the problem with the token, but @jirfag does not answer.

edwarnicke commented 4 years ago

@SVilgelm is @jirfag the only one with the keys?

SVilgelm commented 4 years ago

I'm not sure, but maybe @ernado also can check

ernado commented 4 years ago

I think that only jirfag can check as an org owner :(

SVilgelm commented 4 years ago

even the @golangci/team does not have permissions for this repo

SVilgelm commented 4 years ago

yes, I see the @golangci/core-team has admin permissions for the golangci-lint and golangci-lint-action repos, the @golangci/team has write permissions for same repos. So without @jirfag we cannot do anything with this repo

edwarnicke commented 4 years ago

@SVilgelm Who has permissions for the golangci org? Who ever that is should as a mechanical matter be able to add folks to this repo. Whether they should I leave up to them to figure out :)

SVilgelm commented 4 years ago

The v1.29.0 is available