search

golangci / misspell

Correct commonly misspelled English words in source files
MIT License
22 stars 10 forks source link

misspell -v reporting wrong version #21

Closed JanneKiiskila closed 3 months ago

JanneKiiskila commented 3 months ago

Expected:

Actual:

$ go install github.com/golangci/misspell/cmd/misspell@v0.6.0
go: downloading github.com/golangci/misspell v0.6.0
 11:32 jannek@jannek-P720:~/k8sscripts$ go install github.com/golangci/misspell/cmd/misspell@v0.6.0^C
 11:32 jannek@jannek-P720:~/k8sscripts$ misspell -v
dev
JanneKiiskila commented 3 months ago 
$ go version
go version go1.22.3 linux/amd64

In case it matters, OS details:

$ uname -a
Linux jannek-P720 6.5.0-35-generic #35~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue May  7 09:00:52 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
ldez commented 3 months ago

Hello,

when using go install (this is a local build and not a download) the version is dev because the way to build doesn't have the arguments to use the git information. This is expected because it's how go install works.

A go install of a CLI cannot be compared to Go itself.

You use our binaries or the install script.