search

gold2718 / ccpp-framework

Common Community Physics Package (CCPP-framework)
http://www.dtcenter.org/GMTB/ccpp_doc/
Other
0 stars 1 forks source link

Dimensions are not properly checked #18

Closed cacraigucar closed 4 years ago

cacraigucar commented 5 years ago

I discovered that a scheme which is the second one called using the array o2_xsect had incorrect names for the dimension names in the .meta file. There is no indication from the capgen routine that these dimension names are incorrect (not even valid names) and do not match the dimension names from the first scheme.

The files to demonstrate this bug are MICM_chemistry/src/tuv/oxygen_xsect/molec_ox_xsect.meta and MICM_chemistry/src/tuv/photo_rates/tuv_photolysis.meta. This bug has existed in MICM_chemistry for at least the last month or so, so any recent version of MusicBox should demonstrate the problem.

gold2718 commented 4 years ago

Loop variables should not be allowed in dimensions of init or final phase arguments.

gold2718 commented 4 years ago

I believe this is fixed. The dimension checking has been completely re-implemented (as of CPF_0.2.015) so any new problems are probably new bugs and should have a new issue.