search

goldbergyoni / node-chaos-monkey

Extremly naughty chaos monkey for Node.js
MIT License
228 stars 10 forks source link

Pr 13 eslint #30

Closed GadiRay closed 5 years ago

goldbergyoni commented 5 years ago

@gadi-ray Very cool.

Two questions:

  1. Do we want to engage with additional linters like eslint-plugin-promise and eslint-plugin-security?

  2. Does the lint check currently pass?

GadiRay commented 5 years ago

Thanks @i0natan :)

  1. Sure those are very good eslints, i can add them and use their recommended rules for start. BTW this is just the skeleton for eslints, anyone can add more :+1:
  2. No, there are many errors and warning, I thought of taking care of it in a new PR
goldbergyoni commented 5 years ago

@gadi-ray Forgot to ask, you have permissions to merge, right?