search

goldbergyoni / nodebestpractices

:white_check_mark: The Node.js best practices list (July 2024)
https://twitter.com/nodepractices/
Creative Commons Attribution Share Alike 4.0 International
99.21k stars 10.08k forks source link

chore: fix typo and link syntax #1229

Closed moosashah closed 1 year ago

moosashah commented 1 year ago

@all-contributors please add @moosashah for content

moosashah commented 1 year ago

@elektronik2k5 Hey nick, How do I fix the failing check so that we can get this merged?

elektronik2k5 commented 1 year ago

@rluvaton @goldbergyoni I tried re-running the action but it keeps OOMing:

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

Can we increase the amount of memory the runner has? Or, if it has enough then we may only need to pass the good ole --max_old_space_size=8192 environment variable.

rluvaton commented 1 year ago

I'll merge the PR and try to fix the memory issue

rluvaton commented 1 year ago

@all-contributors please add @moosashah for content