goldbergyoni / nodebestpractices

:white_check_mark: The Node.js best practices list (July 2024)
https://twitter.com/nodepractices/
Creative Commons Attribution Share Alike 4.0 International
99.57k stars 10.12k forks source link

Update limitrequests.md #1287

Closed animir closed 7 months ago

animir commented 10 months ago

Use ioredis package

animir commented 7 months ago

@goldbergyoni Above lint error isn't related to this PR. We should update to ioredis package in the example since previously used redis package has changed how they create Redis client. It is more complicated now and not the best for simple example like that. Current example in master branch doesn't work with the latest redis package. With ioredis it works for any version.

goldbergyoni commented 7 months ago

@animir Great point here, thanks!

And... congrats for the new release of node-rate-limiter-flexible 🥳

Let's make some article or YouTube about rate limiting some day

animir commented 7 months ago

@goldbergyoni Hi, thanks! There are some articles about rate limiting and brute-force protection on Medium I wrote a couple of years ago https://medium.com/@animirr I see you do have YouTube channel. It may be interesting to collaborate. I'll make sure to email you to continue this discussion.