goldenXcode / grafx2

Automatically exported from code.google.com/p/grafx2
0 stars 0 forks source link

Kill page behaving strangely with layers. I think. #502

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Copy page to spare
2. Add layer
3. Click KILL

What is the expected output? What do you see instead?

If on second layer it will just clear the second layer.
If on first layer it will delete the second layer.

If on only layer it will restore the default blank image/palette (perhaps this 
is normal? if both pages are always active and cannot be freed, like they can 
in Dpaint or Brilliance)

Original issue reported on code.google.com by ilija.melentijevic on 10 Aug 2012 at 3:13

GoogleCodeExporter commented 9 years ago
I'm not exactly sure what you mean. Kill should behave like Undo then 
additionally erase the history step you were viewing. ie. If your last change 
was accidentally clearing the image, Kill undoes it and makes it un-redoable.

I've just tested and can't produce any dodgy situation.
The history's first step is a blank image with current skin's palette and 
window dimension, even if you loaded an image from command-line. So if you Undo 
or kill history steps repeatedly, it's normal to finish with this NO_NAME.GIF.

This said, Kill is barely used at all, so it's not impossible that it has had a 
bug since long time ago.

Original comment by yrizoud on 10 Aug 2012 at 3:58

GoogleCodeExporter commented 9 years ago
By the way, all history functions (Undo/Redo/Kill) can be misleading with 
hidden layers, because the system doesn't keep an history of which layers were 
selected and visible :
For example if you have an image with 8 layers and only layer 7/8 is hidden, 
inserting a layer (for example between 1 and 2) shifts the hidden layer to 8/9; 
but if you immediately undo, the hidden layer "stays" 8, not the original one.

Original comment by yrizoud on 10 Aug 2012 at 4:03

GoogleCodeExporter commented 9 years ago
Ah! All well then, I didn't know kill was history related at all!
You can safely close the issue, I assumed it would erase one of the two pages 
completely. My bad, I should RTFM sometime. :)

Original comment by ilija.melentijevic on 10 Aug 2012 at 11:11

GoogleCodeExporter commented 9 years ago
Well at least it makes it apparent grafx2 needs some kind of "New file" 
function, with a wizard to choose between preferred presets : size, palette, 
anim or layers...

Original comment by yrizoud on 11 Aug 2012 at 2:39