search

goldfire / howler.js

Javascript audio library for the modern web.
https://howlerjs.com
MIT License
23.99k stars 2.23k forks source link

Feature Request: ECMAScript module (ESM) bundle support #1367

Open endigo9740 opened 4 years ago

endigo9740 commented 4 years ago

Howler.js is providing the following warning in the Angular CLI for the new v10 release:

Screen Shot 2020-06-29 at 12 36 18 PM

Starting with Angular 10 the Angular CLI now provide warnings for CommonJS modules. Read more about it here: https://blog.angular.io/version-10-of-angular-now-available-78960babd41

When you use a dependency that is packaged with CommonJS, it can result in larger slower applications. Starting with version 10, we now warn you when your build pulls in one of these bundles. If you’ve started seeing these warnings for your dependencies, let your dependency know that you’d prefer an ECMAScript module (ESM) bundle.

And here: https://angular.io/guide/build#configuring-commonjs-dependencies

It is recommended that you avoid depending on CommonJS modules in your Angular applications. Depending on CommonJS modules can prevent bundlers and minifiers from optimizing your application, which results in larger bundle sizes. Instead, it is recommended that you use ECMAScript modules in your entire application. For more information, see How CommonJS is making your bundles larger

They reference the following article regarding the issues with CommonJS: https://web.dev/commonjs-larger-bundles/

Additionally I've seen a few discussions by Angular staff members on Github discussing potentially dropping CommonJS support by default, and making it an opt-in feature in the future.

I realize the Angular team is taking a very strong armed approach here, but their reasoning seems solid. Needless to say I'd love to see ESM support if possible. Thanks!

Noaber commented 4 years ago

Any news on this, getting warnings with my Angular 10 app. Thanks in advance.

ctp-tCG commented 3 years ago

Seems ironic that

howler.js is an audio library for the modern web

yet still no ES module... Any movement on this would be greatly appreciated.

Greenheart commented 3 years ago

I refactored the core modules to native ESM today, keeping the public API intact, as well as the implementation details.

Check it out and please help out if you also want to use ESM in production!

1518