search

goldfire / howler.js

Javascript audio library for the modern web.
https://howlerjs.com
MIT License
23.29k stars 2.21k forks source link

fix old opera detection for three digit version numbers (100+) #1676

Closed bikubi closed 9 months ago

bikubi commented 11 months ago

Issue/Feature

Fixes mp3 playback on Opera v100+

Related Issues

https://github.com/goldfire/howler.js/issues/1670

Solution

The browser sniffing regex did not expect version numbers with three digits. 100 got misinterpreted as 10, which is less than the cut-off version 33.

We improve the regex.

Reproduction/Testing

You might not notice in all examples. Our application listens to loaderror. You can add that to the radio example.
Also update your Opera before testing...

Breaking Changes

N/A

Cvolton commented 10 months ago

can confirm this PR fixes the issue, would be awesome if this got merged, so I could stop relying on using a fork in my application

goldfire commented 9 months ago

Thanks for catching this! v2.2.4 is now live on npm with this fix.