search

goldfirere / ghc

Mirror of ghc repository. DO NOT SUBMIT PULL REQUESTS HERE
http://www.haskell.org/ghc/
Other
25 stars 1 forks source link

Explicit specificity #74

Open goldfirere opened 6 years ago

goldfirere commented 6 years ago

Take 3.

To use: Keep pushing commits to your own branch, as you've been doing. The commits will appear here as well. But this provides a place to have a conversation about the patch and for us to comment on the code with a nice interface. I don't expect that this PR will ever get merged. Instead, when the patch is ready, you'll submit to Phabricator and we'll merge into GHC central from there.

plaidfinch commented 6 years ago

Ah, okay, that makes sense. So I should not worry about pushing the "Merge pull request" button, then?

By the way, I didn't get a notification of your PR until you @-mentioned me, so good thing you checked. I marked your repository as "Watched" so now I will get such notifications in the future (although if there's enough discussion traffic on your fork then this might become cumbersome).

goldfirere commented 6 years ago

This isn't really a request for anything to be pulled -- just a very convenient reviewing interface. Now that you've participated in the PR, I believe you'll get notified about future comments here. But there's very low traffic here, anyway. Sorry for not explaining earlier.

plaidfinch commented 6 years ago

No worries! I'm currently going through your comments on #73.