search

goldfirere / units

The home of the units Haskell package
94 stars 19 forks source link

Regenerate `haskell-ci.yml` to use Ubuntu 20.04 runners #73

Closed RyanGlScott closed 4 months ago

RyanGlScott commented 5 months ago

This regenerates haskell-ci.yml with a more recent haskell-ci version. Among other benefits, this changes the CI runners to use Ubuntu 20.04. Previously, they were targeting Ubuntu 18.04, which is no longer supported by GitHub Actions.

RyanGlScott commented 5 months ago

The GHC 7.10 CI failure (seen here) is due to https://github.com/ndmitchell/safe/issues/35. We could either wait for a resolution to that issue first, or we could drop support for GHC 7.10 as a workaround.

RyanGlScott commented 5 months ago

https://github.com/ndmitchell/safe/issues/35 has now been fixed via a Hackage revision, so the failing GHC 7.10.3 CI job should hopefully pass now if you restart it.

RyanGlScott commented 5 months ago

Oops, the version bounds should have been constraints: safe < 0.3.18, not safe < 3.18. I've pushed a commit which rectifies this, and I've verified on my fork that CI finally passes with these changes.