Webpack 4 support - Githubissues

goldhand / sw-precache-webpack-plugin

Webpack plugin that generates a service worker using sw-precache that will cache webpack's bundles' emitted assets. You can optionally pass sw-precache configuration options to webpack through this plugin.

MIT License

1.44k stars 104 forks source link

Webpack 4 support #135

Closed moimael closed 6 years ago

moimael commented 6 years ago

[ ] I'm submitting a bug report
[x] I'm submitting a feature request
[ ] I'm submitting a support request

webpack version: 4.x

sw-precache-webpack-plugin version: 0.11.4

Please tell us about your environment: Linux Fedora 27

Browser: Chrome 64

Expected/desired behavior: Now that webpack 4 is in beta and 1 month away from final release, this plugin should probably be upgraded to work with it.

lencioni commented 6 years ago

Aside from updating the peerDependencies semver range to allow for v4, what else needs to be done here?

andriijas commented 6 years ago

Depends I guess but the changelog says

plugin method is backward-compatible
Plugins should use Compiler.hooks.xxx.tap(<plugin name>, fn) now

webpack/webpack#6357