search

goldhand / sw-precache-webpack-plugin

Webpack plugin that generates a service worker using sw-precache that will cache webpack's bundles' emitted assets. You can optionally pass sw-precache configuration options to webpack through this plugin.
MIT License
1.44k stars 104 forks source link

fix mkdirp to opendir #165

Closed takeaways closed 3 years ago

takeaways commented 4 years ago

I tried to build my application with it, however it showed me "mkdirp is not a fuction" so I fixed to use in my application.

and it works, thanks

vagrantsn commented 3 years ago

Any updates on this? I am facing the same issue when upgrading from Webpack v4 to v5 and can confirm this PR fixes it :rocket:

cc @goldhand

takeaways commented 3 years ago

@vagnervst thank you for doing this for me.

vagrantsn commented 3 years ago

@nomadGeonilJang I didn't. The referenced commit you saw here was one I made on another repo, intended to be a temporary fix while your PR isn't merged. You can reopen this pull request with my suggested fix as it is still useful =)

tomaszczechowski commented 3 years ago

for me this works outputFileSystem.opendir(path.resolve(filepath, '..') I experience the issue after migrating from webpack 4 to 5.

Please merge this PR.

CC @goldhand