goldibex / targaryen

Test Firebase security rules without connecting to Firebase.
ISC License
242 stars 36 forks source link

fix: validate path #132

Closed dinoboff closed 7 years ago

dinoboff commented 7 years ago

Validate path navigation rules or node and when creating/updating data nodes.

Fixes #131

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 94.514% when pulling c0d76dd24ecca0d5af05a0b5fd2307f9e8602b46 on dinoboff:fix/131 into 986d743b73b565b46c8f6586d0643402c54cf81d on goldibex:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 94.514% when pulling c0d76dd24ecca0d5af05a0b5fd2307f9e8602b46 on dinoboff:fix/131 into 986d743b73b565b46c8f6586d0643402c54cf81d on goldibex:master.

dinoboff commented 7 years ago

I am assuming it's a bug fix since the console doesn't allow to import object with keys having invalid character (targaryen was skipping them) and the simulator doesn't allow to simulate operation with an invalid path.

It will however break tests relying on this bug. It will nonetheless be shipped with v3.0.3.