fix: regression in rule evaluation of invalid path

goldibex / targaryen

Test Firebase security rules without connecting to Firebase.

ISC License

242 stars 36 forks source link

fix: regression in rule evaluation of invalid path #137

Closed dinoboff closed 7 years ago

dinoboff commented 7 years ago

Firebase allows RuleDataSnapshot methods to receive invalid path, which PR #132 broke.

This fix allows to traverse DataNode and Ruleset with invalid path and denies read/write operation with invalid path instead, and it keeps denying creating DataNode with invalid keys

coveralls commented 7 years ago

Coverage decreased (-0.01%) to 94.503% when pulling 9fd6fffc0ffece04a79cb6f21fb725c4bd0f7bcc on dinoboff:fix/issues/136 into a3e60f82ba971bb97c842052db25c2c89e150186 on goldibex:master.

chetbox commented 7 years ago

:+1: Can confirm this fixes the problem. Thanks for the quick turnaround.