minor: better explain what the --tmp-dir option really does

goldmann / docker-squash

Docker image squashing tool

MIT License

848 stars 109 forks source link

Closed jkremser closed 6 years ago

jkremser commented 6 years ago

I had no idea that this option actually creates the directory and at the end it is removed. So I used it this way:

docker-squash --tmp-dir /home/jkremser/Downloads <hash>

And it failed with:

...
2017-11-27 21:30:48,854 root         ERROR    Preparing temporary directory failed
...

and deleted my ~/Downloads :(

That's the reasoning behind opening this simple PR. The word 'created' should protect people from using the existing directories.

goldmann commented 6 years ago

Ouch. Sorry to mislead you!

goldmann commented 6 years ago

Merged, thanks!