--output-path description is confused

goldmann / docker-squash

Docker image squashing tool

MIT License

848 stars 109 forks source link

--output-path description is confused #195

Closed StoneMoe closed 1 year ago

StoneMoe commented 4 years ago

  --output-path OUTPUT_PATH
                        Path where the image should be stored after squashing.
                        If not provided, image will be loaded into Docker
                        daemon

It sounds like "If you specify the output path, squashed image won't load back to docker daemon" But in fact, It still load the squashed image into docker daemon, store as file is just an addition behavior, but not a replacement.

torzsmokus commented 3 years ago

s/confused/confusing/

rnc commented 2 years ago

I think the logic for image saving/storing got changed in https://github.com/goldmann/docker-squash/pull/47 and potentially there might be a bug there. Potentially there should be a elif in https://github.com/goldmann/docker-squash/blob/main/docker_squash/squash.py#L100 ; however load_image is parameterised for the tests but the CLI never uses it - it could be added to the CLI.