ML: Adding MSSQL to the list of platforms as it is NOT apparent that it is an option. Updating the PS script to handle username and password a little cleaner.

goldmansachs / obevo

Obevo is a database deployment tool that handles enterprise scale schemas and complexity

Apache License 2.0

236 stars 56 forks source link

ML: Adding MSSQL to the list of platforms as it is NOT apparent that it is an option. Updating the PS script to handle username and password a little cleaner. #275

Closed mistarheeOG closed 4 years ago

mistarheeOG commented 4 years ago

I don't know if I actually need those copyright attributions as I don't care and they're ugly. If I don't have to add them, please let me know.

shantstepanian commented 4 years ago

Thanks for the contribution! Your fix works locally for me w/out the check style error, so I've accepted your PR. I'll fix it on master if I still see it have issues

mistarheeOG commented 4 years ago

Thanks for the contribution! Your fix works locally for me w/out the check style error, so I've accepted your PR. I'll fix it on master if I still see it have issues

Ok, thanks for checking that. I'm having issues with Maven on my Mac so glad you were able to get that sorted!

shantstepanian commented 4 years ago

Fyi, the issue was a minor thing w/ Checkstyle, where that line comment needs to be surrounded by block quotes, given where it is in the file structure

I've updated the code and docs accordingly

https://github.com/goldmansachs/obevo/commit/ed8e632bdbf821bc823b2f4690ba5919b68f6b46

Will be merged in once I get my feature on my own branch working