search

goldsky / FileDownload-R

FileDownload snippet for MODX revolution
12 stars 7 forks source link

Strict Standards Violation #11

Closed MacConin closed 11 years ago

MacConin commented 11 years ago

running modx 2.2.6 with php5.4.9 and getting the following error/warning:

Only variables should be passed by reference in ....../core/components/filedownload/models/filedownload/filedownload.class.php on line 583

caused by: [[!FileDownloadLink? &getFile=[[+download]]

goldsky commented 11 years ago

would you please check that line? what mine has is $ext = strtolower(end(explode('.', $baseName))); is it that code?

MacConin commented 11 years ago

yepp, correct.

goldsky commented 11 years ago

Here goes the fix https://github.com/goldsky/FileDownload-R/commit/1e46e2a19118b5326bbd9648faf92530e2988105

MacConin commented 11 years ago

Wow, thx

In return, you'll get a premium 1a german translation for your package.

Mac

Von unterwegs gesendet.

Am 02.01.2013 um 05:12 schrieb rico notifications@github.com:

Here goes the fix 1e46e2a

— Reply to this email directly or view it on GitHub.

goldsky commented 11 years ago

awesome. i'll look forward to it.

MacConin commented 11 years ago

Hi Rico,

prop_fd.userGroups_desc there is a 'noDownlod setting' mentioned.

'...JavaScript alert with the message contained in the noDownload language setting...'

where is that defined? System settings?

Attached are the two translatins.

Cheers, and have a good start in 2013

rico schrieb uns am 04.01.13 06:06:

awesome. i'll look forward to it.

— Reply to this email directly or view it on GitHub https://github.com/goldsky/FileDownload-R/issues/11#issuecomment-11872693.

mit freundlichen Grüßen

Mac Conin

mac.conin@conin.de

CONIN Werbeagentur GmbH | Tel 0221 - 92 189 12 Mauritiussteinweg 86-88 | Fax 0221 - 92 189 16 50676 Köln

Geschäftsführer: Andrea Horn, Matthias Conin Amtsgericht Köln HRB 62100 | UStId DE257752493