search

goldsky / FileDownload-R

FileDownload snippet for MODX revolution
12 stars 7 forks source link

Foldernames with '&' not showing up in list #24

Closed studiovlijmscherp closed 10 years ago

studiovlijmscherp commented 11 years ago

When trying to use foldernames with an ampersand in the '&getDir' property, the folder doens't show up. All the other folders are shown.

When setting '&browseDirectories=1', on one of the parents folders the folders with an ampersand are shown.

studiovlijmscherp commented 11 years ago

It has something to do with filedownload.class.php line 115: $realpath = realpath($path);

when replacing it with: $realpath = realpath(htmlspecialchars_decode($path));

The folders with an '&' are displayed, but all folders & files are displayed twice.

goldsky commented 11 years ago

oh, wow... having non alphanumeric character to the foldernames is simply not a good practice. what OS are you on?

studiovlijmscherp commented 11 years ago

Hi!

I know... But my client insists...

Server os is Linux CentOs.

Op 17 aug. 2013 om 05:39 heeft rico notifications@github.com het volgende geschreven:

oh, wow... having non alphanumeric character to the foldernames is simply not a good practice. what OS are you on?

— Reply to this email directly or view it on GitHubhttps://github.com/goldsky/FileDownload-R/issues/24#issuecomment-22804877 .

goldsky commented 11 years ago

Quoted from http://www.cyberciti.biz/faq/linuxunix-rules-for-naming-file-and-directory-names/

Avoid using the following characters from appearing in file names:
1. /
2. >
3. <
4. |
5. :
6. &
studiovlijmscherp commented 11 years ago

Hi Rico,

Yes... I know and understand. But the folders are named after company client names ( wich contain &). No way to make this work?

Michiel

Verstuurd vanaf mijn iPad

Op 17 aug. 2013 om 10:06 heeft rico notifications@github.com het volgende geschreven:

Quoted from http://www.cyberciti.biz/faq/linuxunix-rules-for-naming-file-and-directory-names/

Avoid using the following characters from appearing in file names:

  1. /
  3. <
  4. |
  5. :
  6. &

— Reply to this email directly or view it on GitHubhttps://github.com/goldsky/FileDownload-R/issues/24#issuecomment-22807637 .

goldsky commented 10 years ago

I don't think it works with ampersand, so I'm closing this issue.