golemcloud / golem

Golem is an open source durable computing platform that makes it easy to build and deploy highly reliable distributed systems.
https://learn.golem.cloud/
Apache License 2.0
530 stars 59 forks source link

Comprehensive test for interpreter, new global input type info tests, support match on all types, restricted global variables and other fixes #978

Closed afsalthaj closed 1 month ago

afsalthaj commented 1 month ago

Fixes #876 Fixes #881 Fixes #954

afsalthaj commented 1 month ago

It was difficult to satisfy wasm-wave syntax here: https://github.com/golemcloud/golem/blob/migrate_tests/golem-rib/src/interpreter/comprehensive_test/mock_data.rs#L155, mainly due to abstract error messages and not mentioning the exact reason: invalid token at 31..32.

If we are using the error message of https://github.com/golemcloud/wasm-rpc/blob/main/wasm-rpc/src/text.rs#L25 (which in turn comes from wasm-wave crate) back to users, then we need to be careful. Hopefully they will improving since it got migrated.