The above tested code has caller, callee (and a callee2 which isn't significant here)
And the following scenarios have been tested with this change
[x] caller depends on callee-stub
[x] callee in turn depends on caller-stub
[x] caller depends on caller-stub itself (just to see we are not regressing this fix that was done earlier - it shouldn't)
[x] Multiple runs of cargo make build-flow after code changes (i.e, adding imports and adding actual usage) is also done. Multiple runs are important as there are state changes after the first run.
The PR https://github.com/golemcloud/wasm-rpc/pull/42 hasn't tried to solve transitive dependency case, and it looks like much more easier than the direct-cyclic dependency case. There is no logical intervention into the direct cyclic dependency fix in this PR, still I have included that in the test case.
afsalthaj
commented
3 months ago
https://github.com/afsalthaj/testwasmrpc/tree/transitive_dependency
The above tested code has
caller,callee(and acallee2which isn't significant here)And the following scenarios have been tested with this change
callerdepends oncallee-stubcalleein turn depends oncaller-stubcallerdepends oncaller-stubitself (just to see we are not regressing this fix that was done earlier - it shouldn't)cargo make build-flowafter code changes (i.e, adding imports and adding actual usage) is also done. Multiple runs are important as there are state changes after the first run.The PR https://github.com/golemcloud/wasm-rpc/pull/42 hasn't tried to solve transitive dependency case, and it looks like much more easier than the direct-cyclic dependency case. There is no logical intervention into the direct cyclic dependency fix in this PR, still I have included that in the test case.