golemfactory / clay

Golem is creating a global market for computing power.

https://golem.network

GNU General Public License v3.0

2.91k stars 286 forks source link

use more if TYPE_CHECKING #5162

Closed etam closed 4 years ago

Wiezzel commented 4 years ago

Is this work-in-progress or ready for review?

etam commented 4 years ago

it's an almost ready work-in-progress. Unfortunately using GitHubs WIP disables running tests on buildbot. But I think it should pass this time.

etam commented 4 years ago

it's ready

Wiezzel commented 4 years ago

What exactly is the benefit of doing this? Does importing stuff like GetConfigFn, EnvId or EnvironmentManager impair the performance?

etam commented 4 years ago

It should improve performance of starting the application, by avoiding unneeded imports.

codecov[bot] commented 4 years ago

Codecov Report

Merging #5162 into b0.23 will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            b0.23    #5162      +/-   ##
==========================================
- Coverage   89.99%   89.95%   -0.04%     
==========================================
  Files         238      238              
  Lines       22465    22449      -16     
==========================================
- Hits        20217    20194      -23     
- Misses       2248     2255       +7