golemfactory / clay

Golem is creating a global market for computing power.

https://golem.network

GNU General Public License v3.0

2.91k stars 286 forks source link

Fix config cannot be updated #5171

Closed etam closed 4 years ago

etam commented 4 years ago

Fixes #5151

Wiezzel commented 4 years ago

And you're gonna have a hard time silencing mypy when dealing with class decorators...

etam commented 4 years ago

I have worries about potential race conditions occurring when the config is updated at the very moment when environment gets enabled/disabled. Environment state could change between status check in update_config and calling super().update_config or assigning _next_config.

How about now?

And you're gonna have a hard time silencing mypy when dealing with class decorators...

It wasn't that bad :)

codecov[bot] commented 4 years ago

Codecov Report

Merging #5171 into b0.23 will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            b0.23    #5171      +/-   ##
==========================================
+ Coverage   89.93%   89.95%   +0.01%     
==========================================
  Files         238      238              
  Lines       22460    22482      +22     
==========================================
+ Hits        20200    20224      +24     
+ Misses       2260     2258       -2