search

golemfactory / clay

Golem is creating a global market for computing power.
https://golem.network
GNU General Public License v3.0
2.91k stars 286 forks source link

Fix default benchmark reported value #5184

Closed kmazurek closed 4 years ago

kmazurek commented 4 years ago

When running a benchmark via RPC (comp.environment.benchmark), the result reported back to the client (CLI or Electron app) is expected to be a single floating-point value being the performance rating.

In the case of the default benchmark a BenchmarkResult object was being returned, resulting in WAMP message serialization failing. This changes the default benchmark callback to return the underlying performance value.

codecov[bot] commented 4 years ago

Codecov Report

Merging #5184 into b0.23 will increase coverage by 2.24%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            b0.23    #5184      +/-   ##
==========================================
+ Coverage   87.69%   89.93%   +2.24%     
==========================================
  Files         238      238              
  Lines       22496    22496              
==========================================
+ Hits        19728    20232     +504     
+ Misses       2768     2264     -504