golemfactory / clay

Golem is creating a global market for computing power.
https://golem.network
GNU General Public License v3.0
2.91k stars 284 forks source link

golemcli binary should output a message when golemapp is not running #5201

Open ghost opened 3 years ago

ghost commented 3 years ago

Rationale

When first running and installing golem, an error message is an output that terms need to be accepted among other things. When trying to run the golemcli after exiting, it outputs an ambiguous error message that the host is unavailable (os error 111). This should include

Description

Functional specification

golemcli, the component which interacts with golemapp.

User Interface

The golemcli should output something like; ERROR: Cannot connect to host. Is golemapp running?

Technical specification

If not already present, have golemcli check to see if golemapp is running. If not, output a more verbose error.

Dependencies

M/A

Sub-components

N/A

Blockers

N/A

Additional tests

N/A

QA

Ensure that golemcli can correctly detect if golemapp is running, and return an error message if not.

Test scenarios:

N/A

Base test process

QA limited to the single feature (in case of very trivial changes)

New feature tests

N/A

Positive Scenario 1

No error code is output.

Negative Scenario 1

An error message is output notify the user they need to start golemapp

Possible regressions

N/A

Progress

Development

Dev QA

Please choose the priority label for QA. It is set to the lowest by default. To setup higher priority please change the label P0 label is set for Severity-Critical/Effort-easy P1 label is set for Severity-Critical/Effort-hard P2 label is set for Severity-Low/ Effort-easy P3 label is set for Severity-Low/Effort-hard

QA team

Issues encountered during QA

When adding an issue here, please update testing scenarios and QA progress above

ghost commented 3 years ago

This is the first issue i've submitted on github so sorry if I've screwed it up :)