Support for explicit IP addresses and `depends_on` clause (requirements for the webapp example)

golemfactory / dapp-runner

GNU Lesser General Public License v3.0

5 stars 6 forks source link

Support for explicit IP addresses and `depends_on` clause (requirements for the webapp example) #32

Closed shadeofblue closed 2 years ago

shadeofblue commented 2 years ago

closes #34 closes #31

shadeofblue commented 2 years ago

Nice tests :)

I've added two proposals for additional test scenarios that look missing, but maybe they are not useful - I'm not sure.

General comment: maybe entrypoint could also have field(default_factory: list)? This would let as delete a big bunch of "entrypoint": [].

the entrypoint is required so not supposed to have a default