search

golemfactory / golem-certificate

GNU Lesser General Public License v3.0
0 stars 1 forks source link

Using private key from an OpenPGP capable smartcard #31

Closed evik42 closed 1 year ago

evik42 commented 1 year ago

Resolves #21

evik42 commented 1 year ago

I wonder: maybe we should have some "e2e-like" CLI scenarios added for testing? i.e.: have root cert then sign it and verify if it is good. Or have root cert, sign with it some leaf or node-descriptor and verify

To test this you would need a build server with a smartcard. I tested the code manually and also added tests to the certificate validator tests that use the new signature schema.

MrDarthShoe commented 1 year ago

I wonder: maybe we should have some "e2e-like" CLI scenarios added for testing? i.e.: have root cert then sign it and verify if it is good. Or have root cert, sign with it some leaf or node-descriptor and verify

To test this you would need a build server with a smartcard. I tested the code manually and also added tests to the certificate validator tests that use the new signature schema.

I meant to create test-cases for cli not only for smartcard, but for regular signatures also. But definitely it can be done in other task